Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped gcl plugin in fluentd-gcp #41397

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Bumped gcl plugin in fluentd-gcp #41397

merged 1 commit into from
Feb 16, 2017

Conversation

piosz
Copy link
Member

@piosz piosz commented Feb 14, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 14, 2017
@piosz piosz added this to the v1.5 milestone Feb 14, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 14, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@piosz piosz changed the title WIP: Bumped gcl plugin in fluentd-gcp Bumped gcl plugin in fluentd-gcp Feb 16, 2017
@piosz piosz assigned mwielgus and unassigned saad-ali Feb 16, 2017
@piosz piosz added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 16, 2017
@piosz
Copy link
Member Author

piosz commented Feb 16, 2017

It's ready for the review.

@crassirostris
Copy link

SGTM, leaving for Marcin to review

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@mwielgus
Copy link
Contributor

/approve

@mwielgus mwielgus added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Feb 16, 2017
@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: mwielgus, piosz, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 60d46e8 into kubernetes:release-1.5 Feb 16, 2017
@k8s-ci-robot
Copy link
Contributor

@piosz: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins CRI GCE e2e d25e36a link @k8s-bot cri e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@crassirostris crassirostris

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@piosz @k8s-reviewable @crassirostris @mwielgus @wojtek-t @k8s-github-robot @k8s-ci-robot @k8s-cherrypick-bot @mikedanese @saad-ali